Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

follow: init at 0.0.1-alpha.17 #341356

Merged
merged 2 commits into from
Sep 25, 2024
Merged

follow: init at 0.0.1-alpha.17 #341356

merged 2 commits into from
Sep 25, 2024

Conversation

iosmanthus
Copy link
Contributor

@iosmanthus iosmanthus commented Sep 12, 2024 •
edited
Loading

Description of changes

pack https://github.com/RSSNext/Follow.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Sep 12, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Sep 12, 2024
@sifmelcara
Copy link
Member

Is it possible to build from source?

@iosmanthus iosmanthus mentioned this pull request Sep 18, 2024
Merged
@iosmanthus iosmanthus changed the title follow: init at 0.0.1-alpha.10 follow: init at 0.0.1-alpha.13 Sep 18, 2024
@iosmanthus
Copy link
Contributor Author

@bobby285271 PTAL ❤️

@iosmanthus
Copy link
Contributor Author

Is it possible to build from source?

Done

NickCao
NickCao reviewed Sep 19, 2024
View reviewed changes
Copy link
Member

@NickCao NickCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks pretty good!

pkgs/by-name/fo/follow/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/fo/follow/package.nix Show resolved Hide resolved
@iosmanthus
Copy link
Contributor Author

@NickCao comment addressed, PTAL.

NickCao
NickCao approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@NickCao NickCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash everything into two commits, and we are good to go!

  1. maintainers: add iosmanthus
  2. follow: init at 0.0.1-alpha.13

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 22, 2024
@iosmanthus iosmanthus changed the title follow: init at 0.0.1-alpha.13 follow: init at 0.0.1-alpha.16 Sep 24, 2024
@iosmanthus iosmanthus changed the title follow: init at 0.0.1-alpha.16 follow: init at 0.0.1-alpha.17 Sep 24, 2024
@iosmanthus
Copy link
Contributor Author

@NickCao Done, PTAL ❤️

@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 25, 2024
@NickCao
Copy link
Member

NickCao commented Sep 25, 2024

@ofborg build follow

@NickCao NickCao merged commit d4de366 into NixOS:master Sep 25, 2024
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickCao NickCao NickCao approved these changes

Assignees
No one assigned
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iosmanthus @sifmelcara @NickCao @wegank